Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing concurrent execution of fields resolution #3119

Merged
merged 1 commit into from
Jan 31, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
using GraphQL;
using GraphQL.Execution;
using GraphQL.Language.AST;
using System;

namespace OrchardCore.Apis.GraphQL.Services
{
/// <summary>
/// Defines a custom execution strategy for queries such that async lambdas are not executed in parallel.
/// c.f. https://github.com/OrchardCMS/OrchardCore/issues/3029
/// </summary>
public class SerialDocumentExecuter : DocumentExecuter
{
private static IExecutionStrategy ParallelExecutionStrategy = new ParallelExecutionStrategy();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused field?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, just so that we know it exists. The actual implementation in graphql uses it, and this is what the issue is about. I prefer to leave it then.

You can say a comment would be better :/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can say a comment would be better :/

I dare say it, yeah 😄

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought the same thing earlier when looking into another issue and looking at it @PinpointTownes ;)

private static IExecutionStrategy SerialExecutionStrategy = new SerialExecutionStrategy();
private static IExecutionStrategy SubscriptionExecutionStrategy = new SubscriptionExecutionStrategy();

protected override IExecutionStrategy SelectExecutionStrategy(ExecutionContext context)
{
switch (context.Operation.OperationType)
{
case OperationType.Query:
return SerialExecutionStrategy;

case OperationType.Mutation:
return SerialExecutionStrategy;

case OperationType.Subscription:
return SubscriptionExecutionStrategy;

default:
throw new InvalidOperationException($"Unexpected OperationType {context.Operation.OperationType}");
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public Startup(IShellConfiguration configuration,
public override void ConfigureServices(IServiceCollection services)
{
services.AddSingleton<IDependencyResolver, RequestServicesDependencyResolver>();
services.AddSingleton<IDocumentExecuter, DocumentExecuter>();
services.AddSingleton<IDocumentExecuter, SerialDocumentExecuter>();
services.AddSingleton<IDocumentWriter, DocumentWriter>();

services.AddScoped<ISchemaFactory, SchemaService>();
Expand Down