-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing concurrent execution of fields resolution #3119
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
36 changes: 36 additions & 0 deletions
36
src/OrchardCore.Modules/OrchardCore.Apis.GraphQL/Services/SerialDocumentExecuter.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
using GraphQL; | ||
using GraphQL.Execution; | ||
using GraphQL.Language.AST; | ||
using System; | ||
|
||
namespace OrchardCore.Apis.GraphQL.Services | ||
{ | ||
/// <summary> | ||
/// Defines a custom execution strategy for queries such that async lambdas are not executed in parallel. | ||
/// c.f. https://github.com/OrchardCMS/OrchardCore/issues/3029 | ||
/// </summary> | ||
public class SerialDocumentExecuter : DocumentExecuter | ||
{ | ||
private static IExecutionStrategy ParallelExecutionStrategy = new ParallelExecutionStrategy(); | ||
private static IExecutionStrategy SerialExecutionStrategy = new SerialExecutionStrategy(); | ||
private static IExecutionStrategy SubscriptionExecutionStrategy = new SubscriptionExecutionStrategy(); | ||
|
||
protected override IExecutionStrategy SelectExecutionStrategy(ExecutionContext context) | ||
{ | ||
switch (context.Operation.OperationType) | ||
{ | ||
case OperationType.Query: | ||
return SerialExecutionStrategy; | ||
|
||
case OperationType.Mutation: | ||
return SerialExecutionStrategy; | ||
|
||
case OperationType.Subscription: | ||
return SubscriptionExecutionStrategy; | ||
|
||
default: | ||
throw new InvalidOperationException($"Unexpected OperationType {context.Operation.OperationType}"); | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unused field?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, just so that we know it exists. The actual implementation in graphql uses it, and this is what the issue is about. I prefer to leave it then.
You can say a comment would be better :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dare say it, yeah 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thought the same thing earlier when looking into another issue and looking at it @PinpointTownes ;)