-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use NullStringLocalizer by default #3344
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
29 changes: 29 additions & 0 deletions
29
src/OrchardCore/OrchardCore/Localization/NullStringLocalizerFactory.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
using System; | ||
using System.Collections.Generic; | ||
using System.Globalization; | ||
using System.Linq; | ||
using Microsoft.Extensions.Localization; | ||
|
||
namespace OrchardCore.Localization | ||
{ | ||
internal class NullStringLocalizerFactory : IStringLocalizerFactory | ||
{ | ||
public IStringLocalizer Create(Type resourceSource) => NullStringLocalizer.Instance; | ||
public IStringLocalizer Create(string baseName, string location) => NullStringLocalizer.Instance; | ||
|
||
private class NullStringLocalizer : IStringLocalizer | ||
{ | ||
public static NullStringLocalizer Instance { get; } = new NullStringLocalizer(); | ||
|
||
public LocalizedString this[string name] => new LocalizedString(name, name); | ||
|
||
public LocalizedString this[string name, params object[] arguments] | ||
=> new LocalizedString(name, string.Format(name, arguments)); | ||
|
||
public IEnumerable<LocalizedString> GetAllStrings(bool includeParentCultures) | ||
=> Enumerable.Empty<LocalizedString>(); | ||
|
||
public IStringLocalizer WithCulture(CultureInfo culture) => Instance; | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm not wrong if anyone asking DI for the current
IStringLocalizer
an exception will be thrown because theNullStringLocalizer
isprivate
Have a look to
NullLoggerProvider
https://github.com/aspnet/Extensions/blob/f162f1006bf8954f0102af8ff98c04077cf21b04/src/Logging/Logging.Abstractions/src/NullLoggerProvider.csThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are wrong ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So can you tell me the expected type?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We always inject a typed localizer which resolves
StringLocalizer<TResourceSource>
which injects and usesIStringLocalizerFactory
which here is ourNullStringLocalizerFactory
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it .. it will return
NullStringLocalizerFactory.NullStringLocalizer
as you mentioned because it is defined as nested typethanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem, it was not clear to me either ;)