GraphQL Schema #6639
Closed
GraphQL Schema #6639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jetski5822
reviewed
Aug 12, 2020
|
|
||
| await context.Response.WriteAsync(printer.Print()); | ||
|
|
||
| return; |
There was a problem hiding this comment.
you dont need the return here?
Jetski5822
reviewed
Aug 12, 2020
|
|
||
| using (var printer = new SchemaPrinter(schema)) | ||
| { | ||
| context.Response.ContentType = "application/text"; |
There was a problem hiding this comment.
shouldnt this be application/json?
Jetski5822
reviewed
Aug 12, 2020
| { | ||
| private readonly RequestDelegate _next; | ||
|
|
||
| public SchemaMiddleware(RequestDelegate next) |
There was a problem hiding this comment.
you could probably ditch this ctor as its not used
|
|
||
| public async Task Invoke(HttpContext context, ISchemaFactory schemaService) | ||
| { | ||
| var schema = await schemaService.GetSchemaAsync(); |
There was a problem hiding this comment.
we should probably check permissions .. dont wanna leak the schema just because graphql is turned on ...
|
|
||
| await context.Response.WriteAsync(printer.Print()); | ||
| } | ||
| } |
There was a problem hiding this comment.
think you still need to invoke _next ?
|
Closing. It was just a test to see if we could export the GraphQL schema. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export GraphQL Schema to text file.
Call
https://localhost:44300/api/schema.graphql