Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Escape \r\n #77

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Escape \r\n #77

merged 1 commit into from
Dec 13, 2023

Conversation

Skrypt
Copy link
Contributor

@Skrypt Skrypt commented Dec 13, 2023 •
edited
Loading

Tested with:

S["Webhook {0} with subscription of {1} deletion failed. \r\n{3}"

Result:

msgid "Webhook {0} with subscription of {1} deletion failed. \r\n{3}"
msgstr ""

Added unit test for \r and \n

Fixes #76

@Skrypt Skrypt marked this pull request as ready for review December 13, 2023 19:06
@hishamco hishamco merged commit b952718 into OrchardCoreContrib:main Dec 13, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hishamco hishamco hishamco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

String with \r\n will not get translated properly.
2 participants
@Skrypt @hishamco