-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
At Cannot read property 'PropTypes' of undefined
when toggling
#103
Comments
Thanks for the report! I'm unable to replicate this locally. It looks like an issue with
|
On Mon, 18 Apr 2016 at 11:47 Michael Kelly [email protected] wrote:
|
And more Atom Version: 1.7.1 Stack TraceFailed to activate the advanced-open-file package
Commands
Config{
"core": {
"autoHideMenuBar": true,
"disabledPackages": [
"linter-eslint",
"nuclide-file-tree",
"nuclide-file-watcher",
"nuclide-flow",
"nuclide-hack",
"nuclide-hg-repository",
"nuclide-language-hack",
"nuclide-quick-open",
"nuclide-remote-projects",
"nuclide-type-hint",
"fonts",
"atom-json-editor",
"atom-terminal",
"json-schema"
],
"themes": [
"one-dark-ui",
"atom-material-syntax"
]
}
} Installed Packages# User
advanced-open-file, v0.15.0
atom-beautify, v0.29.4
atom-material-syntax, v0.4.6
atom-typescript, v8.8.1
atom-wallaby, v1.0.7
atom-yeoman, v0.3.15
build, v0.59.0
build-gulp, v0.7.0
build-npm-apm, v0.10.0
docblockr, v0.7.3
editorconfig, v1.3.0
hyperclick, v0.0.35
language-babel, v2.17.3
last-cursor-position, v0.9.0
linter, v1.11.4
linter-jsonlint, v1.2.3
linter-less, v2.4.2
linter-pep8, v1.2.1
linter-tslint, v0.9.1
minimap, v4.22.1
pain-split, v1.4.0
pigments, v0.26.0
pretty-json, v1.0.3
terminal-plus, v0.14.5
travis-ci-status, v1.0.0
# Dev
No dev packages |
I wonder if this is a dupe of #104? Or at least related to the issues with react-for-atom. I'm reverting 0.15.0 and going to investigate this more closely. |
I've published 0.16.1, which re-adds the React rewrite and uses React directly. I can confirm it coexists fine with packages using react-for-atom, but I didn't have any React-using packages on hand to confirm if it avoids the supposed issues with multiple Reacts on a single page. However, as far as I can tell from other posts, multiple Reacts only breaks if components between them mix, which, as I understand it, shouldn't happen with Atom packages in general. Can ya'll get the latest version and test if it works? |
Works for me! :D |
works for me |
Hooray! Now we wait to see if anyone reports a new issue! Thanks all! |
It looks like the issue is that you have Hyperclick imports an outdated version of react-for-atom that exports React as the default, something like This shouldn't be an issue that package authors like @Osmose should have to deal with though. I'm bringing this up with @zertosh to see how we can make this go away. |
Atom Version: 1.7.1
System: Mac OS X 10.11.2
Thrown From: advanced-open-file package, v0.15.0
Stack Trace
Failed to activate the advanced-open-file package
Commands
Config
Installed Packages
The text was updated successfully, but these errors were encountered: