Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heightmap proxy shadow caster is borked cuz lod #1001

Closed
TerrificTrifid opened this issue Dec 16, 2024 · 2 comments · Fixed by #1010
Closed

Heightmap proxy shadow caster is borked cuz lod #1001

TerrificTrifid opened this issue Dec 16, 2024 · 2 comments · Fixed by #1010
Assignees
Labels
bug Something isn't working fixed in dev Instead of closing issues when you fix them in dev just add this.

Comments

@TerrificTrifid
Copy link
Member

What Happened?

The change to heightmaps being 2 lods caused the proxy shadow caster to not find the mesh filter because its on CubeSphere which has no mesh filter.
image
image

What was supposed to happen?

The shadow caster should be on lod 1 (lowest) so it gets the mesh filter

Platform

None

Mods

No response

Logs

No response

@TerrificTrifid TerrificTrifid added the bug Something isn't working label Dec 16, 2024
@xen-42
Copy link
Member

xen-42 commented Dec 18, 2024

ok u fix it

@AnonymousStrangerOW
Copy link
Contributor

one of my testers (gamewyrm) has also brought up to me that the proxy shadow caster doesn't project any shadows from nh-generated planets on the clouds of a planet that's also generated by new horizons. this is especially true if your planet is a moon orbiting a planet with clouds, like in our scenario.

this might be related to the issue.

@xen-42 xen-42 mentioned this issue Jan 6, 2025
@xen-42 xen-42 added the fixed in dev Instead of closing issues when you fix them in dev just add this. label Jan 6, 2025
@xen-42 xen-42 closed this as completed in d983295 Jan 6, 2025
xen-42 added a commit that referenced this issue Jan 6, 2025
## Minor features
- Added an option to use a detail for asteroid belts, instead of just
procgen.
- Also added asteroid belt options for gravity and random orientation.
- Added `selectable` to map mode info, allowing you to make the map mode
icon not able to be selected (useful for bodies without ship logs like
stars) Fixes #1003

## Improvements
- Added option separate from Debug for visualizing quantum object
visibility shapes

## Bug fixes
- Fixed the proxy shadow caster on heightmaps, so they cast shadows onto
other bodies better (fixes #1001)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fixed in dev Instead of closing issues when you fix them in dev just add this.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants