Adding new facts and sub-entries to vanilla ship log entries #996
Labels
feature
Features that should be implemented
fixed in dev
Instead of closing issues when you fix them in dev just add this.
Comments
Merged
xen-42
added a commit
that referenced
this issue
Dec 18, 2024
## Minor features - Modded ship log entries with the same ID as an existing entry are now merged into that original entry, allowing for new rumor and explore facts and sub-entries to be added to vanilla ship log entries. Implements #996
Merged
xen-42
added
the
fixed in dev
xen-42
added a commit
that referenced
this issue
Dec 18, 2024
## Minor features - Added `gravityAlignmentRadiusOverride`, overrides how far the player must be from the planet for their feet to automatically orient towards the ground. - Added `allowOutsideItems` to system config, allows preventing items being brought into other systems (implements #997) - Modded ship log entries with the same ID as an existing entry are now merged into that original entry, allowing for new rumor and explore facts and sub-entries to be added to vanilla ship log entries. Implements #996 (thanks @Hawkbat!) - Allow planets to choose whether they're factored into calculating the radius of the solar system using `trackForSolarSystemRadius` (used for zooming/panning distance/speed and autopilot auto-returning to solar system). Thanks @ZygZagGaming! ## Bug fixes - Fixes a ship log softlock on Archipelago (not randomizer) caused by CantAffordaName making a planet called "Planet that fixes glitches" and then immediately deleting it (this in fact caused glitches)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feature
For mods that involve vanilla locations, it would be nice to be able to add additional rumor and explore facts as well as sub-entries in order to connect base game content to the new modded content. Modifying or merging changes into the base game entries would be out of scope for this request; only adding new facts and entries that then get attached to the correct vanilla entry.
I'm thinking the easiest way to implement this is by allowing "dummy" entries in player-created ship log XML files that share the same ID as a vanilla entry. The facts and sub-entries attached to this dummy entry would be relocated to the vanilla entry and the dummy entry would be discarded. The other fields would be ignored (unless we allowed some of them to be merged/overridden as a future enhancement).
Code-wise, we can look for any previously loaded ship log entries with the same ID in
ShipLogManager, strip the XML for those entries from the XML file we feed intoRumorModeBuilder.AddShipLogXML, then pass the child XML nodes to theShipLogFactandShipLogEntryconstructors with the parent ID of the vanilla entry and add the resulting objects to the arrays on the vanilla entry.Context
No response
The text was updated successfully, but these errors were encountered: