Airsea fixes and doc update #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add parameters
atm_partial_pressure_min_zero (default false)
ocean_conc_min_zero (default false)
to limit partial pressure or concentration to > 0.0
when calculating fluxes.
Previous behaviour was to limit ocean concentration to > 0.0, but only
when isotopes not in use.
This was inconsistent, and wrong in some cases eg if a configuration
explicitly allowed -ve ocean O2 to represent unresolved CH4/H2S etc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix for ReactionAirSea:
Add parameters
to limit partial pressure or concentration to > 0.0 when calculating fluxes.
Previous behaviour was to limit ocean concentration to > 0.0, but only when isotopes not in use.
This was inconsistent, and wrong in some cases eg if a configuration explicitly allowed -ve ocean O2 to represent unresolved CH4/H2S etc.
Also update doc and add references