CMake build doesn't set -fvisibility=hidden while Autotools does

[diizzyy]

I'm going to assume that it has been overlooked, CMake provides a switch for this too.
https://cmake.org/cmake/help/latest/prop_tgt/LANG_VISIBILITY_PRESET.html can be used to toggle this

Tested on FreeBSD 14.2 (amd64) with PCRE2 10.45

[NWilson]

Oops! I was vaguely aware of this from when I was doing some testing previously. I was lazy. When I added the CI checks for cmake --install I intended to add some assertions with nm that the so files have the expected symbols... but forgot.

I'll add some tests and fix it.

[diizzyy]

Sounds great, thanks!

[NWilson]

@diizzyy What did you observe that was a problem? The CMakeLists.txt file includes the following: set(CMAKE_C_VISIBILITY_PRESET hidden)

When I run with verbose build I can see that -fvisibility=hidden is passed on the command args to GCC, on Linux. Is this a specific FreeBSD issue with CMake?

[diizzyy]

Grr.. My build env had some unintended cruft, I re-checked and it works as intended. I apologize for the noise

[NWilson]

In #693 I added additional testing, to verify the contents of the .so files are as expected. This did actually discover an issue with the CMake build on Solaris, so I'm glad I did it.