Add tests to check shared object contents #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NWilson
commented
Feb 11, 2025
| CMAKE_VERSION VERSION_LESS 3.31 AND | ||
| CMAKE_C_COMPILER_ID STREQUAL "SunPro" AND | ||
| CMAKE_C_COMPILER_VERSION VERSION_GREATER_EQUAL 5.15) | ||
| set(CMAKE_C_COMPILE_OPTIONS_VISIBILITY "-fvisibility=") |
There was a problem hiding this comment.
@carenas I think you know about this fix! We need to ship it in our CMakeLists, if we want to support the version of CMake that's shipped by Oracle and their latest Oracle Developer Studio.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to ensure that the symbols included in shared object files (.so, .dylib, .dll) are as expected.
This verifies that our Autoconf and CMake builds are using the
-fvisibilityflags and attributes correctly.As it turns out, the CMake build on Solaris is not working, and was exposing internal symbols due to a CMake issue.