Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc: Code janitorial work #10448

Merged
merged 21 commits into from
Dec 24, 2023
Merged

Misc: Code janitorial work #10448

merged 21 commits into from
Dec 24, 2023

Conversation

stenzek
Copy link
Contributor

@stenzek stenzek commented Dec 22, 2023

Description of Changes

  • Moves a few things over to C++20 replacements, rather than the wrappers we currently use for compatibility.
  • Simplify the assertions, pxAssertDev and pxAssertMsg were basically the same, so collapse that back into one.
  • Replace the generic CRT assertions with pxAssert (only affects devbuilds, previously they wouldn't trigger).
  • Cut out a lot of the cruft in Pcsx2Defs.h, mainly irrelevant platforms/compilers.
  • Remove explicit PrecompiledHeader.h includes, the build system force includes it.
  • Simplify the intrinsic file includes for future platforms.
  • Add all the missing includes that were indirectly pulled in from PrecompiledHeader.h for pch-disabled builds.

Since I was editing most of the cpp files anyway, I replaced all the old license headers with small and compact SPDX headers.

Rationale behind Changes

No functional changes, but general cleanup.

Suggested Testing Steps

Test compressed games (CHD/CSO).
Make sure performance hasn't changed in HW and SW.

@stenzek stenzek merged commit 3230287 into PCSX2:master Dec 24, 2023
12 checks passed
@stenzek stenzek deleted the misc branch December 24, 2023 04:03
CookiePLMonster added a commit to CookiePLMonster/pcsx2 that referenced this pull request Dec 31, 2023
refractionpcsx2 pushed a commit that referenced this pull request Dec 31, 2023
GovanifY added a commit that referenced this pull request Jan 8, 2024
GovanifY added a commit that referenced this pull request Jan 8, 2024
refractionpcsx2 pushed a commit that referenced this pull request Jan 8, 2024
vertver pushed a commit to vertver/pcsx2-gdbserver that referenced this pull request Apr 4, 2024
vertver pushed a commit to vertver/pcsx2-gdbserver that referenced this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants