Include destroyable sparks for disabled fireworks (#972)

Signed-off-by: applenick <[email protected]>
PGMDev · Mar 19, 2022 · fdc17ea · fdc17ea
1 parent f84a52c
commit fdc17ea
Showing 1 changed file with 13 additions and 11 deletions.
diff --git a/core/src/main/java/tc/oc/pgm/destroyable/Destroyable.java b/core/src/main/java/tc/oc/pgm/destroyable/Destroyable.java
@@ -358,17 +358,19 @@ public DestroyableHealthChange handleBlockChange(
           this.lastSparkTime = now;
 
           // Spawn a firework where the block was
-          Firework firework =
-              FireworkMatchModule.spawnFirework(
-                  blockLocation,
-                  FireworkEffect.builder()
-                      .with(FireworkEffect.Type.BURST)
-                      .withFlicker()
-                      .withColor(this.getOwner().getFullColor())
-                      .build(),
-                  0);
-
-          NMSHacks.skipFireworksLaunch(firework);
+          if (PGM.get().getConfiguration().showFireworks()) {
+            Firework firework =
+                FireworkMatchModule.spawnFirework(
+                    blockLocation,
+                    FireworkEffect.builder()
+                        .with(FireworkEffect.Type.BURST)
+                        .withFlicker()
+                        .withColor(this.getOwner().getFullColor())
+                        .build(),
+                    0);
+
+            NMSHacks.skipFireworksLaunch(firework);
+          }
 
           // Players more than 64m away will not see or hear the fireworks, so just play the sound
           // for them