Implement dye color option for teams #1066
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, team's dye color is always automatically derived from the chat color specified in
color
, while those conversions are often good enough sometimes they don't allow enough flexibility. Teams may now override that default by setting the dye color directly:It affects:
team-color="true"
(eg: hardened clay, carpet, wool, stained glass...)It does not affect:
team-color="true"
(armor color continues to use chat color, as they're not tied to a list)Side note: deleted "overhead-color" property on teams, it was undocumented and unused for very long, so it served no purpose whatsoever.
The PR has been tested and works as intended