Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement dye color option for teams #1066

Merged
merged 1 commit into from
Oct 7, 2022
Merged

Implement dye color option for teams #1066

merged 1 commit into from
Oct 7, 2022

Conversation

Pablete1234
Copy link
Member

Before this PR, team's dye color is always automatically derived from the chat color specified in color, while those conversions are often good enough sometimes they don't allow enough flexibility. Teams may now override that default by setting the dye color directly:

<teams>
  <team id="blue" max="10"  color="blue" dye-color="light blue">Blue</team>
  <team id="red" max="10"  color="dark red" dye-color="pink">Red</team>
</teams>

It affects:

  • Control point display regions
  • Wool color inside the payload
  • Blocks given via kits using team-color="true" (eg: hardened clay, carpet, wool, stained glass...)

It does not affect:

  • Armor given with team-color="true" (armor color continues to use chat color, as they're not tied to a list)

Side note: deleted "overhead-color" property on teams, it was undocumented and unused for very long, so it served no purpose whatsoever.

The PR has been tested and works as intended

@Pablete1234 Pablete1234 added the feature New feature or request label Oct 7, 2022
@Pablete1234 Pablete1234 requested a review from Electroid as a code owner October 7, 2022 19:16
@Electroid Electroid merged commit 99127f9 into dev Oct 7, 2022
@Electroid Electroid deleted the dye-colors branch October 7, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Development

Successfully merging this pull request may close these issues.

2 participants