Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Trample in Cause Filter #1086

Merged
merged 2 commits into from
Oct 21, 2022
Merged

Fix Trample in Cause Filter #1086

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11d8638
Fix <cause> Filter
CoWinkKeyDinkInc Oct 21, 2022
ad699f8
Update comment
CoWinkKeyDinkInc Oct 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion core/src/main/java/tc/oc/pgm/filters/matcher/CauseFilter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,9 @@ public Class<? extends MatchQuery> queryType() {
@Override
public boolean matches(MatchQuery query) {
Event event = query.getEvent();
if (event instanceof GeneralizedEvent) {
// Prevent PlayerTrampleBlockEvent from casting, which will turn into PlayerCoarseMoveEvent
// which doesn't work for trample
if (event instanceof GeneralizedEvent && !(event instanceof PlayerTrampleBlockEvent)) {
event = ((GeneralizedEvent) event).getCause();
}

Expand Down