Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better spectate #840

Merged
merged 10 commits into from
Nov 13, 2021
Merged

Better spectate #840

merged 10 commits into from
Nov 13, 2021

Conversation

KingOfSquares
Copy link
Contributor

Fixes the bug where players in spectating mode would bug out whenever the player they are spectating died or changed teams.

A couple of QOL changes for the spectator as well:

  • Kills/Deaths related to the player you are spectating will show up in bold in chat. (And on death setting OWN, so always)
  • When the player you are spectating dies the you will see the same death message as the player you are spectating

Signed-off-by: KingSimon [email protected]

@applenick applenick added the feature New feature or request label Mar 28, 2021
TheMolkaPL
TheMolkaPL previously approved these changes Apr 3, 2021
View reviewed changes
Copy link
Contributor

@TheMolkaPL TheMolkaPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@Pablete1234 Pablete1234 mentioned this pull request Apr 26, 2021
Closed
Pablete1234
Pablete1234 previously approved these changes Aug 13, 2021
View reviewed changes
@KingOfSquares @Pablete1234
Better spectate
ae624a1 
Signed-off-by: KingSimon <[email protected]>
@KingOfSquares @Pablete1234
remove redundant import
f5c527a 
Signed-off-by: KingSimon <[email protected]>
@KingOfSquares @Pablete1234
Change message for spectators when player is dead
f16f4d8 
Signed-off-by: KingSimon <[email protected]>
@KingOfSquares @Pablete1234
changes from feedback
63305ef 
Signed-off-by: KingSimon <[email protected]>
@KingOfSquares @Pablete1234
Dont send death rot packet to spectators
7a978df 
- Eject players when vanishing

Signed-off-by: KingSimon <[email protected]>
@KingOfSquares @Pablete1234
Remove unused code
2330278 
Signed-off-by: KingSimon <[email protected]>
@KingOfSquares @Pablete1234
Dont hardcode in exclusion of spectators in the packet to viewers method
329b0f1 
Signed-off-by: KingSimon <[email protected]>
@KingOfSquares @Pablete1234
pablo fix
196239f 
Signed-off-by: KingSimon <[email protected]>
@KingOfSquares @Pablete1234
format
7aac7a7 
Signed-off-by: KingSimon <[email protected]>
Pablete1234
Pablete1234 previously approved these changes Nov 12, 2021
View reviewed changes
@Pablete1234 Pablete1234 added the ready PR is ready to merge label Nov 12, 2021
@Electroid Electroid merged commit 2c71c6c into PGMDev:dev Nov 13, 2021
@KingOfSquares KingOfSquares deleted the better-spectate branch November 13, 2021 18:34
applenick added a commit to applenick/PGM that referenced this pull request Nov 14, 2021
@applenick
Fix missing death messages
f683cf0 
* Caused by PGMDev#840 providing a null player when spectator target is not set

Signed-off-by: applenick <[email protected]>
@applenick applenick mentioned this pull request Nov 14, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@applenick applenick applenick left review comments

@Electroid Electroid Electroid approved these changes

@TheMolkaPL TheMolkaPL TheMolkaPL left review comments

@Pablete1234 Pablete1234 Pablete1234 left review comments

Assignees
No one assigned
Labels
feature New feature or request ready PR is ready to merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@KingOfSquares @Electroid @applenick @TheMolkaPL @Pablete1234