Keep picker visible during blitz #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: applenick <[email protected]>
Electroid
approved these changes
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keep picker visible during blitz
During blitz the picker is hidden from the player after the match starts. While this makes sense for those who have participated and have been eliminated, it's not user friendly for those who have joined after the match has already begun or did not feel like playing.
This PR makes it so the picker is only hidden on blitz matches after you have been eliminated. Those who did not join will still be shown the picker, and in doing so able to understand they're not able to join the match :)
Examples
Join Example - Still being shown the picker
Death Example - Picker hidden from players eliminated
Signed-off-by: applenick [email protected]