Apply colors to TextFormatter with size of 1 #904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Patrick <[email protected]>
|
Build failed, but it doesn't look like it's my fault. It compiled properly on my end. |
Seems to be a problem with ViaVersion's repo. It most likely worked on your end due to having a copy of the 3.0.2 ViaVersion cached in your local maven repo (from previous builds of PGM). I just submitted #905 which once merged should fix the compile issue. |
Electroid
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered by @calcastor, where the colour on the gamemode title does not apply to maps using a single
<gamemode>tag.This function is used in a handful of places and I've tested some of them.