Ensure doDaylightCycle is set to correct value on match start #917
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#879 ensures that game rules like
doDaylightCycle
anddoFireTick
are only enabled once a match starts, if the map has them enabled. However, it seems that the definition ofdoDaylightCycle
from thelevel.dat
files of maps unintentionally takes precedence over the default setting of<timelock>
to off, when<timelock>
anddoDaylightCycle
are both undefined within a map's XML. This PR ensures that the default<timelock>
setting ofoff
again takes precedence over the map world's setting, while also fixing an overlooked albeit small error that ensuresdoFireTick
is disabled once a match ends.