Fix broadcast module unloading #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #938 where reloading a map with tips/alerts would cause them to no longer display.
This was introduced in 529ab16#diff-02f93e0776e398491425d5c04f3cd44595d292c296dae08e0412e890d524c994.
The issue identified above is caused by the
unloadof theBroadcastMatchModuleclearing the map of broadcasts which is actually in theBroadcastModule(MapModule) and not a locally created/used variable. When the map is replayed the map module is reused but no longer contains data. Ondisablealready stops running countdowns so the unload doesn't need to do any extra clean up.The match module could work on a copy of the data but it isn't mutated anyway (other than the current clearing of it 😆).
Signed-off-by: Pugzy [email protected]