Add InvalidXMLException for spawn regions #948
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a minor issue where PGM will load a map that uses improper XML that has been deprecated in 1.3.6.
When a user attempts to load the map, PGM will fail to load it because it can't find the spawn region for it. The map will eventually load (in correct regions) after trying to cycle to it again, but it's still quite fiddly of a process.
Invalid XML (for proto 1.4.0, valid below 1.3.6)
Valid XML
The new convention is to define the spawn regions inside a
<region>
,<regions>
or aregion
attribute in<spawn>
.Merry Christmas everyone :-)