Add bowDamageTaken #951
Merged
Add bowDamageTaken #951
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calcastor
force-pushed
the
bowdamagetaken
branch
3 times, most recently
from
2529e63 to
f61b8d2
Compare
KingOfSquares
suggested changes
Jan 10, 2022
|
Is this actually a breaking change? It doesn't appear so? |
I spoke with @dentmaged again and he wasn't sure why he thought so originally. I'm not sure if that's still the case. |
calcastor
force-pushed
the
bowdamagetaken
branch
2 times, most recently
from
2b1ff9f to
52807cb
Compare
Signed-off-by: BT (calcastor/mame) <[email protected]>
Signed-off-by: BT (calcastor/mame) <[email protected]>
Signed-off-by: BT (calcastor/mame) <[email protected]>
calcastor
force-pushed
the
bowdamagetaken
branch
from
52807cb to
cf94aa8
Compare
Pablete1234
approved these changes
Jan 29, 2022
Electroid
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR distinguishes between damage taken and damage taken by bow, similarly to how damage dealt and bow damage dealt are separated.
The first commit in this PR is from the version of PGM deployed on Stratus (originally https://github.com/ShinyDialga/PGM/tree/stratus, currently https://github.com/calcastor/PGM/tree/stratus). I expanded on the change to add it to PGM's verbose stats menu.
I spoke with @dentmaged about this a few months back and he was pretty sure a change like this would incur API breakage, so that is something to note. I am also unaware of any potential reasoning for this being left out intentionally, beyond speculation.