Remove chest protection inventory check #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pugzy <[email protected]>
Electroid
approved these changes
Mar 20, 2022
applenick
added a commit
to applenick/PGM
that referenced
this pull request
Mar 25, 2022
This reverts commit 963f02a.
applenick
added a commit
to applenick/PGM
that referenced
this pull request
Apr 21, 2022
This reverts commit 963f02a.
applenick
added a commit
to applenick/PGM
that referenced
this pull request
Apr 22, 2022
This reverts commit 963f02a.
applenick
added a commit
to applenick/PGM
that referenced
this pull request
May 13, 2022
This reverts commit 963f02a.
applenick
added a commit
to applenick/PGM
that referenced
this pull request
Jun 8, 2022
This reverts commit 963f02a.
applenick
added a commit
to applenick/PGM
that referenced
this pull request
Jun 12, 2022
This reverts commit 963f02a.
applenick
added a commit
to applenick/PGM
that referenced
this pull request
Jun 26, 2022
This reverts commit 963f02a.
applenick
added a commit
to applenick/PGM
that referenced
this pull request
Jul 17, 2022
This reverts commit 963f02a.
applenick
added a commit
to applenick/PGM
that referenced
this pull request
Jul 20, 2022
This reverts commit 963f02a.
applenick
added a commit
to applenick/PGM
that referenced
this pull request
Jul 23, 2022
This reverts commit 963f02a.
applenick
added a commit
to applenick/PGM
that referenced
this pull request
Aug 1, 2022
This reverts commit 963f02a.
applenick
added a commit
to applenick/PGM
that referenced
this pull request
Aug 3, 2022
This reverts commit 963f02a.
applenick
added a commit
to applenick/PGM
that referenced
this pull request
Aug 4, 2022
This reverts commit 963f02a.
applenick
added a commit
to applenick/PGM
that referenced
this pull request
Sep 3, 2022
This reverts commit 963f02a.
applenick
added a commit
to applenick/PGM
that referenced
this pull request
Sep 13, 2022
This reverts commit 963f02a.
applenick
added a commit
to applenick/PGM
that referenced
this pull request
Sep 18, 2022
This reverts commit 963f02a.
applenick
added a commit
to applenick/PGM
that referenced
this pull request
Sep 23, 2022
This reverts commit 963f02a.
applenick
added a commit
to applenick/PGM
that referenced
this pull request
Sep 24, 2022
This reverts commit 963f02a.
applenick
added a commit
to applenick/PGM
that referenced
this pull request
Sep 24, 2022
This reverts commit 963f02a.
applenick
added a commit
to applenick/PGM
that referenced
this pull request
Sep 24, 2022
This reverts commit 963f02a.
applenick
added a commit
to applenick/PGM
that referenced
this pull request
Oct 1, 2022
This reverts commit 963f02a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To replicate, join a team, start the match and try to change your inventory within the first 2 seconds, the event is cancelled.
For the first 2 seconds of a match non-player inventory interactions are cancelled with the aim of preventing modifications with chests for some unknown reason (maybe a bug of the past). The way this check is written currently prevents regular player inventory actions as the inventory type of a player is set as
CRAFTING(a legacy (craft/sport)bukkit issue) this causes the event to cancel as it does not match the allowed types ofPLAYERandCREATIVE.This check is not present within the OvercastNetwork ProjectAres final release and was removed in the same way as this commit. The inventory interact event check aimed mainly at observers which is mixed in with this random chest feature is also moved to the
EventFilterMatchModulewith other similar purpose listners.Signed-off-by: Pugzy [email protected]