Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GoalQuery to PGM api #987

Merged
merged 2 commits into from
May 13, 2022
Merged

Add GoalQuery to PGM api #987

merged 2 commits into from
May 13, 2022

Conversation

KingOfSquares
Copy link
Contributor

Signed-off-by: KingSimon [email protected]

Pablete1234
Pablete1234 requested changes Apr 15, 2022
View reviewed changes
Copy link
Member

@Pablete1234 Pablete1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should use probably be using generics as they are meant to be used, not just as wildcards everywhere

core/src/main/java/tc/oc/pgm/api/filter/query/GoalQuery.java Outdated Show resolved Hide resolved
core/src/main/java/tc/oc/pgm/filters/query/GoalQuery.java Outdated Show resolved Hide resolved
core/src/main/java/tc/oc/pgm/filters/query/GoalQuery.java Outdated Show resolved Hide resolved
core/src/main/java/tc/oc/pgm/filters/query/GoalQuery.java Outdated Show resolved Hide resolved
@KingOfSquares
Copy link
Contributor Author

You should use probably be using generics as they are meant to be used, not just as wildcards everywhere

Good point.

@Pablete1234 Pablete1234 added the ready PR is ready to merge label May 12, 2022
@Electroid Electroid merged commit ea2bb37 into PGMDev:dev May 13, 2022
@KingOfSquares KingOfSquares deleted the goalquery-api branch May 19, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pablete1234 Pablete1234 Pablete1234 approved these changes

@Electroid Electroid Electroid approved these changes

Assignees
No one assigned
Labels
ready PR is ready to merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KingOfSquares @Electroid @Pablete1234