Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate Config::create() #4828

Merged
merged 1 commit into from
Feb 26, 2020
Merged

Deprecate Config::create() #4828

merged 1 commit into from
Feb 26, 2020

Conversation

DocFX
Copy link
Contributor

@DocFX DocFX commented Feb 18, 2020 •
edited
Loading

[Config] Add the complete use of config name with:

  • static constructor (passing name to __construct())
  • default safe name on static constructor as well
  • setter in ConfigInterface.php
  • setter in Config.php

Instead of forcing "default".

@DocFX DocFX changed the title [Config] Add the complete use of config name with: [Config] Add the complete use of config name Feb 18, 2020
julienfalque
julienfalque reviewed Feb 18, 2020
View reviewed changes
src/ConfigInterface.php Outdated Show resolved Hide resolved
src/Config.php Outdated Show resolved Hide resolved
@DocFX DocFX force-pushed the master branch 8 times, most recently from bfc4887 to e5ed645 Compare February 20, 2020 14:53
julienfalque
julienfalque reviewed Feb 20, 2020
View reviewed changes
src/Config.php Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
@DocFX DocFX force-pushed the master branch 6 times, most recently from 9340787 to 9c8b9ca Compare February 20, 2020 17:21
SpacePossum
SpacePossum reviewed Feb 20, 2020
View reviewed changes
tests/ConfigTest.php Outdated Show resolved Hide resolved
@DocFX DocFX force-pushed the master branch 7 times, most recently from 223e22e to e9cb147 Compare February 21, 2020 10:45
julienfalque
julienfalque reviewed Feb 21, 2020
View reviewed changes
.php_cs.dist Outdated Show resolved Hide resolved
@julienfalque julienfalque changed the title [Config] Add the complete use of config name Deprecate Config::create() Feb 21, 2020
@julienfalque julienfalque added this to the 2.17.0 milestone Feb 21, 2020
@DocFX DocFX force-pushed the master branch 2 times, most recently from 6325a13 to 3eaf018 Compare February 25, 2020 15:47
@DocFX DocFX force-pushed the master branch 2 times, most recently from 3592016 to 3112029 Compare February 26, 2020 10:45
@DocFX
[Config] Deprecate the static Config constructor so that people can i…
6581369 
…nstantiate it with a name by following the README.rst instructions and use a custom one.
@SpacePossum SpacePossum added the RTM Ready To Merge label Feb 26, 2020
@SpacePossum
Copy link
Contributor

Thank you @DocFX.

@SpacePossum SpacePossum merged commit 3667675 into PHP-CS-Fixer:master Feb 26, 2020
@SpacePossum SpacePossum removed the RTM Ready To Merge label Feb 26, 2020
@SpacePossum
Copy link
Contributor

and thanks @fabpot for the fast update, much appreciated :)

@DocFX
Copy link
Contributor Author

DocFX commented Feb 26, 2020

It appears I missed the fabbot.io solving, so yeah thanks to you all, and @fabpot :)

@rosier rosier mentioned this pull request Sep 12, 2020
Merged
@endelwar
Copy link

endelwar commented Dec 9, 2020

Config doc still use static call to Config::create()

@julienfalque
Copy link
Member

julienfalque commented Dec 9, 2020 •
edited
Loading

Indeed, this is likely a conflict I didn't solve correctly while doing some rebase with #3475. Do you mind sending a PR to fix this?

@SpacePossum
Copy link
Contributor

#5344

@derrabus derrabus mentioned this pull request Mar 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot left review comments

@maxhelias maxhelias maxhelias approved these changes

@SpacePossum SpacePossum SpacePossum approved these changes

@julienfalque julienfalque julienfalque approved these changes

Assignees
No one assigned
Labels
kind/deprecation
Projects
None yet
Milestone
2.17.0
Development

Successfully merging this pull request may close these issues.
6 participants
@DocFX @SpacePossum @endelwar @julienfalque @fabpot @maxhelias