NamingConventions::isEqual(): minor simplification #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
fredden
approved these changes
Mar 1, 2024
No need to "translate" the ASCII characters from uppercase to lowercase, the PHP native `strcasecmp()` function can do the comparison correctly as it only compares ASCII letters in a case-insensitive way. Ref: https://www.php.net/manual/en/function.strcasecmp.php
jrfnl
force-pushed
the
feature/namingconventions-minor-simplification
branch
from
2bed23d to
c6fabf3
Compare
|
Updated the version number in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to "translate" the ASCII characters from uppercase to lowercase, the PHP native
strcasecmp()function can do the comparison correctly as it only compares ASCII letters in a case-insensitive way.Ref: https://www.php.net/manual/en/function.strcasecmp.php