Tests: fix for PHP 8.4 deprecation of implicitly nullable types #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will work for now. PHPCS 4.0 will remove the whole outdated TestSuite setup as per 25, so by that time, the problem is gone completely. Ref: https://wiki.php.net/rfc/deprecate-implicitly-nullable-types
jrfnl
force-pushed
the
feature/tests-bypass-php-8.4-deprecation
branch
from
8fc669e to
7e3c481
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This should work for now. PHPCS 4.0 will remove the whole outdated TestSuite setup as per #25, so by that time, the problem is gone completely.
Ref: https://wiki.php.net/rfc/deprecate-implicitly-nullable-types
Note: the tests won't pass on PHP 8.4 yet as PHPUnit itself (and its dependencies) still need to release a version which fixes similar issues in PHPUnit itself.
Suggested changelog entry
Test framework: fix PHP 8.4 deprecation