Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ListItemRun in HTML writer #1766

Merged
merged 2 commits into from
Dec 8, 2019
Merged

Add support for ListItemRun in HTML writer #1766

merged 2 commits into from
Dec 8, 2019

Conversation

stefan-91
Copy link

@stefan-91 stefan-91 commented Nov 28, 2019 •
edited
Loading

Description

Add List for docx to html. Implemented ListItemRun for HTML in Writer.

Fixes List item fail #1717 (issue)

Checklist:

  • I have run composer run-script check --timeout=0 and no errors were reported
  • The new code is covered by unit tests (check build/coverage for coverage report)
  • I have updated the documentation to describe the changes

@coveralls
Copy link

Coverage Status

Coverage increased (+0.003%) to 94.622% when pulling 1451fad on stefan-91:develop into b8346af on PHPOffice:develop.

@troosan troosan changed the title Add List for docx to html Add support for ListItemRun in HTML writer Dec 8, 2019
@troosan troosan added this to the v0.18.0 milestone Dec 8, 2019
@troosan troosan merged commit dfea4e1 into PHPOffice:develop Dec 8, 2019
@HammenWS
Copy link

HammenWS commented May 8, 2020

I wonder wonder. Why are paragraphs <p> created instead of actual lists <ul> <ol>?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
0.18.0
Development

Successfully merging this pull request may close these issues.
4 participants
@stefan-91 @coveralls @HammenWS @troosan