Update the regexp to avoid catastrophic backtracking #1809
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reference Issue: #1800
Update from this PR: #1801
When you have multiple Blocks in multiple Rows, some of blocks cannot be replaced
Only the last block was replaced.
This because some word file will drop-line after
xml
tag, and the regular expression engine in different versions cannot find the matched block.Fixes # (issue)
File:
TemplateProcessor.php
Line: 740
Change the regexp pattern to:
Describe:
<w:p
tag that closest to the blockname.<w:p
does not contain any other<w:p
inside it.Checklist:
All Done
composer run-script check --timeout=0
and no errors were reported