reduce branching when checking for MOD operations

PLC-lang · Mar 11, 2024 · 27a4d49 · 27a4d49
1 parent df6170c
commit 27a4d49
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/src/validation/statement.rs b/src/validation/statement.rs
@@ -1354,11 +1354,12 @@ fn validate_assignment_type_sizes<T: AnnotationMap>(
                     .into_iter()
                     .for_each(|(k, v)| map.entry(k).or_default().extend(v));
                 // the RHS type in a MOD expression has no impact on the resulting value type
-                if !matches!(operator, Operator::Modulo) {
-                    get_expression_types_and_locations(right, context, lhs_is_signed_int)
-                        .into_iter()
-                        .for_each(|(k, v)| map.entry(k).or_default().extend(v));
-                }
+                if matches!(operator, Operator::Modulo) {
+                    return map
+                };
+                get_expression_types_and_locations(right, context, lhs_is_signed_int)
+                    .into_iter()
+                    .for_each(|(k, v)| map.entry(k).or_default().extend(v));
             }
             AstStatement::UnaryExpression(UnaryExpression { operator, value })
                 if !operator.is_comparison_operator() =>