Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor src/parser/tests/parser_tests.rs into seperate modules #190

Closed
riederm opened this issue Jul 15, 2021 · 0 comments · Fixed by #194
Closed

Refactor src/parser/tests/parser_tests.rs into seperate modules #190

riederm opened this issue Jul 15, 2021 · 0 comments · Fixed by #194
Labels
good first issue Good for newcomers refactor internal change, cleanup, code-style-improvement

Comments

@riederm
Copy link
Collaborator

riederm commented Jul 15, 2021

Describe the bug
The file src/parser/tests/parser_tests.rs has ~1500 lines and contains tests concerning mulitple parse-topcis raning from Container-Parse-tests, Statement-parse-tests to parse-error-tests

It is hard to find the appropriate location for new tests and to determine whether there are tests missing because its not clear where to look for them?

refactor this file into mulitple modules with a cohesive test-topic like:

  • container-parse-tests
  • statement-parse-tests
  • parse-error-tests (should be moved to appropriate files in parse_errors-folder)
  • etc.
@riederm riederm added enhancement New feature or request refactor internal change, cleanup, code-style-improvement good first issue Good for newcomers and removed enhancement New feature or request labels Jul 15, 2021
ulmer-a added a commit to ulmer-a/rusty that referenced this issue Jul 16, 2021
@ghaith ghaith assigned ghaith and unassigned ghaith Jul 19, 2021
@ghaith ghaith linked a pull request Jul 19, 2021 that will close this issue
ghaith pushed a commit that referenced this issue Jul 19, 2021
Closes #190 

Split parser tests into separate modules to reduce the module sizes.
@ghaith ghaith moved this to Done in Next Jan 9, 2023
@ghaith ghaith added this to Next Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers refactor internal change, cleanup, code-style-improvement
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants