Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"+" should be accepted #633

Closed
rarris opened this issue Nov 7, 2022 · 1 comment
Closed

"+" should be accepted #633

rarris opened this issue Nov 7, 2022 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers language feature (norm) a missing language feature according to iec61131-3

Comments

@rarris
Copy link
Contributor

rarris commented Nov 7, 2022

example:
DINT := +2147483647;
@rarris rarris added the bug Something isn't working label Nov 7, 2022
@riederm riederm added good first issue Good for newcomers language feature (norm) a missing language feature according to iec61131-3 labels Nov 7, 2022
@volsa volsa mentioned this issue Nov 8, 2022
Merged
riederm added a commit that referenced this issue Nov 10, 2022
@volsa @riederm
Support literal numbers with explicit plus sign (#633) (#640)
3a76564 
fix: Support literal numbers with explicit plus sign (#633)

Fixes issue #633 where previously the compiler would
yield an error if it encountered a number with an
explicit plus sign, i.e. the following was previously
not supported but is now
```
foo := +2147483647;
```

Co-authored-by: Mathias Rieder <[email protected]>
@riederm
Copy link
Collaborator

riederm commented Nov 10, 2022

fixed by #640

@riederm riederm closed this as completed Nov 10, 2022
@ghaith ghaith moved this to Done in Next Jan 9, 2023
@ghaith ghaith added this to Next Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers language feature (norm) a missing language feature according to iec61131-3
Projects
Next
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@riederm @rarris