Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse IMPLEMENTS keyword after EXTENDS #1391

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Conversation

mhasel
Copy link
Member

@mhasel mhasel commented Jan 20, 2025

Moves the parse-interface logic after the parsing of EXTENDS keywords in parse_pou.
This allows correct parsing of e.g. FUNCTION_BLOCK bar EXTENDS foo IMPLEMENTS baz, registering the implemented interface for the derived function block.

@mhasel mhasel requested a review from volsa January 20, 2025 12:54
Copy link
Member

@volsa volsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, the error message is a bit weird when you have something like IMPLEMENTS <...> EXTENDS <...> but that is generally something we have to improve on the parser side

@mhasel mhasel merged commit 1f7ee2e into master Jan 20, 2025
21 checks passed
@mhasel mhasel deleted the extending_parsing branch January 20, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants