-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Single line variable declarations #226
Conversation
Codecov Report
@@ Coverage Diff @@
## master #226 +/- ##
==========================================
- Coverage 95.94% 93.51% -2.44%
==========================================
Files 41 34 -7
Lines 15449 9030 -6419
==========================================
- Hits 14822 8444 -6378
+ Misses 627 586 -41 Continue to review full report at Codecov.
|
No idea why coverage went bad :( |
How does the coverage look like if we don't ignore tests? I think you can run gcov locally without much changes. |
Ok I think I somewhat know what is going on. Codecov confuses some stuff because of the config changes... However, since the diff coverage is 100% (which is reasonable) I think we can still merge this and actually don't decrease coverage at all. |
Declare multiple variables with the same type in a single line. Closes #204.