Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parentheses with string size arguments #229

Merged
merged 2 commits into from
Aug 11, 2021

Conversation

ulmer-a
Copy link
Collaborator

@ulmer-a ulmer-a commented Aug 10, 2021

Allows string size expressions to be wrapped in round parentheses as well. Whenever this occurs, a diagnostic is going to be wrapped. Mismatched types of parentheses will also cause a diagnostic to be raised.

This will resolve #209.

@ulmer-a ulmer-a added this to the oscat milestone Aug 10, 2021
@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #229 (39474e0) into master (e159877) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #229      +/-   ##
==========================================
+ Coverage   93.51%   93.52%   +0.01%     
==========================================
  Files          34       34              
  Lines        9030     9054      +24     
==========================================
+ Hits         8444     8468      +24     
  Misses        586      586              
Impacted Files Coverage Δ
src/parser.rs 97.59% <100.00%> (+0.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e159877...39474e0. Read the comment docs.

@ulmer-a ulmer-a requested a review from ghaith August 10, 2021 14:12
@ghaith ghaith merged commit 7e18300 into PLC-lang:master Aug 11, 2021
@ulmer-a ulmer-a deleted the string_size_args branch August 11, 2021 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Support 'Parentheses' as String size arguments
2 participants