build: Speed up playground build slightly #2242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We no longer need to run a build command in the playground on `prql-js`, since the command is now part of `prql-js`'s `preinstall`. This givs us some speedup — 23s down from 32s — but most of the time is still taken up by re-running `wasm-opt`. There's an issue for this in rustwasm/wasm-pack#1152. But probably `wasm-opt` should be run by `build.rs` which knows whether it requires re-running based on changed input files https://doc.rust-lang.org/cargo/reference/build-scripts.html I think the current state is probably OK — we still get instant feedback when developming the playground; this is only required when _starting_ the playground on changing `prql-js`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We no longer need to run a build command in the playground on
prql-js, since the command is now part ofprql-js'spreinstall.This givs us some speedup — 23s down from 32s — but most of the time is still taken up by re-running
wasm-opt.There's an issue for this in rustwasm/wasm-pack#1152. But probably
wasm-optshould be run bybuild.rswhich knows whether it requires re-running based on changed input files https://doc.rust-lang.org/cargo/reference/build-scripts.htmlI think the current state is probably OK — we still get instant feedback when developming the playground; this is only required when starting the playground or changing
prql-js