-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Speed up playground build #2907
Conversation
As discussed in PRQL#1836 (comment)
This works quite well, and solves most of the runtime issues with But unfortunately we get another stack size issue!
So maybe we look at this again after #2908 is solved... |
Changes we can merge now
Since #2908 seems to be solved, we no longer the stack overflow above. But we get a different error —
Searching for this gives a couple of issues: rustwasm/wasm-pack#1050 & webpack/webpack#14087. These both reference https://github.com/wasm-tool/wasm-pack-plugin, which we don't use1. Overall I'm not experienced enough at JS to do this quickly or well, but if someone wants to investigate further, that'd be welcome. Footnotes
|
This now works great! I think because of the move to So I'm merging. |
As discussed in #1836 (comment)