Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update structure of tax depreciation rules #400

Merged
merged 24 commits into from
Jan 7, 2025

Conversation

jdebacker
Copy link
Member

This PR updates the structure of the tax depreciation rules JSON to make it easier to account for multiple years' parameters.

On the pro side, this simplifies the JSON file.

On the con, I believe the new structure means that one cannot update the parameters for who classes of assets at once (e..g, change the depreciation method for all 5-year lived assets), rather one needs to change rules specifically for each asset type.

@codecov-commenter
Copy link

codecov-commenter commented Dec 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.82%. Comparing base (9cf614a) to head (cc518ec).
Report is 25 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #400      +/-   ##
==========================================
- Coverage   99.91%   99.82%   -0.09%     
==========================================
  Files          11       11              
  Lines        1133     1165      +32     
==========================================
+ Hits         1132     1163      +31     
- Misses          1        2       +1     
Flag Coverage Δ
unittests 99.82% <100.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
ccc/__init__.py 100.00% <100.00%> (ø)
ccc/calcfunctions.py 100.00% <100.00%> (ø)
ccc/get_taxcalc_rates.py 98.24% <100.00%> (-1.76%) ⬇️
ccc/parameters.py 100.00% <100.00%> (ø)
ccc/utils.py 98.97% <100.00%> (ø)

@jdebacker jdebacker merged commit a49b7ad into PSLmodels:master Jan 7, 2025
11 checks passed
@jdebacker jdebacker deleted the dp_rule_update branch January 7, 2025 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants