Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test_calculator in preparation for release #2404

Merged
merged 1 commit into from
Mar 18, 2020

Conversation

Peter-Metz
Copy link
Contributor

Minor changes to make sure all pre-release tests (other than documentation) pass before release

@MattHJensen

@codecov
Copy link

codecov bot commented Mar 16, 2020

Codecov Report

Merging #2404 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2404   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          13      13           
  Lines        2751    2751           
======================================
  Hits         2751    2751

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a804d9f...c5e4e55. Read the comment docs.

@codecov
Copy link

codecov bot commented Mar 16, 2020

Codecov Report

Merging #2404 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #2404   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines         2751      2751           
=========================================
  Hits          2751      2751           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a804d9f...c5e4e55. Read the comment docs.

@Peter-Metz
Copy link
Contributor Author

After looking into the reason for the need for this PR (i.e. why there is a small difference between some calculated components of itemized deductions and the total amount of itemized deductions), I haven't been able to find a good explanation. However here are some things to consider:

  • In the past, the margin or error (or "tolerance") has been adjusted when economic projections are updated (as they are in this case).
  • The margin of error disappears for years after 2018.
  • In 2017, the margin of error represents a 0.005% difference between the ID component (c19700) and total ID

cc @MattHJensen

@MattHJensen
Copy link
Contributor

Thanks @Peter-Metz for the PR and for investigating the tolerance increase. I am going to merge this so we can get a release out because people are waiting on it. Could you open up an issue in Tax-Calculator about how this sensitivity test needs documentation? I will tackle it when I have an opportunity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants