We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Result
thiserror
anyhow
panic
https://github.com/search?q=repo%3APSeitz%2Fwana_kana_rust%20panic&type=code
This library can panic and discourages other software from adopting this library.
#13
e.g. https://github.com/orgs/meilisearch/discussions/532#discussioncomment-9999921
https://docs.rs/thiserror/latest/thiserror/ and https://docs.rs/anyhow/latest/anyhow/ are widely used to handle errors without panic.
New APIs like to_kana_safe() and to_romaji_safe() will be appreciated.
to_kana_safe()
to_romaji_safe()
The text was updated successfully, but these errors were encountered:
The library should never panic. Error's don't make sense imo, since it works on a best effort basis.
Here's how I addressed the issue:
Sorry, something went wrong.
Oh snap, looks like all of them are test code. Sorry to bother you.
No branches or pull requests
https://github.com/search?q=repo%3APSeitz%2Fwana_kana_rust%20panic&type=code
This library can
panic
and discourages other software from adopting this library.#13
e.g. https://github.com/orgs/meilisearch/discussions/532#discussioncomment-9999921
https://docs.rs/thiserror/latest/thiserror/ and https://docs.rs/anyhow/latest/anyhow/ are widely used to handle errors without
panic
.New APIs like
to_kana_safe()
andto_romaji_safe()
will be appreciated.The text was updated successfully, but these errors were encountered: