-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
panicked to_romaji "ウーッー" #13
Comments
aipacommander
pushed a commit
to aipacommander/wana_kana_rust
that referenced
this issue
Jun 17, 2023
Closed
This was referenced Oct 9, 2024
meili-bors bot
added a commit
to meilisearch/charabia
that referenced
this issue
Oct 14, 2024
312: Update wana_kana to 4.0.0 r=ManyTheFish a=tats-u # Pull Request ## Related issue - Fixes #313 - meilisearch/meilisearch#3588 (comment) - PSeitz/wana_kana_rust#13 - meilisearch/meilisearch@0fbda63 - https://github.com/orgs/meilisearch/discussions/532#discussioncomment-9999921 ## What does this PR do? `wana_kana` used to easily panic. The panicability made it difficult to adopt it in the Meilisearch core. Update it to the latest version that [doesn't panic](https://github.com/orgs/meilisearch/discussions/532#discussioncomment-10814507). ## PR checklist Please check if your PR fulfills the following requirements: - [x] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)? - [x] Have you read the contributing guidelines? - [x] Have you made sure that the title is accurate and descriptive of the changes? Thank you so much for contributing to Meilisearch! Co-authored-by: Tatsunori Uchino <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Thanks for provide useful library! I'm using this library with meilisearch.
my requests are:
first, maybe convert to "uu" or "uuu".
second is more important. I found this problem when using meilisearch indexing. When this issue occurs, indexing thread is panicked. then, updating document and index are lost.
Japanese notation has many variations and new ones can be created. For example, くぁwせdrftgyふじこlp is valid (slang) Japanese notation.
The text was updated successfully, but these errors were encountered: