Add some comment of CrossMapNormalFunc #1202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qingqing01
reviewed
Jan 22, 2017
| * alpha /min(F, f-[N/2] + N) | ||
| * (1 + ----- * | (Input(x, y))^2 ) ^ (beta) | ||
| * N /max(0, f-[N/2]) | ||
| * |
There was a problem hiding this comment.
- 看这个公式，无法看出 across channel (or maps)
- Input/Output是4D的tensor，注释里面如果忽略第一维的话， Input(x, y) 是不是应该写作 Input(c, x, y) (或者 Input[, , , ]) ?
- 求和符号， 直接用 sum 会不会更清晰些， 或者
--
\
/
--
- paper的公式里是 +k，而不是+1。
- alpha不用除N吧？
另外，如果比较复杂的公式，如果拆解开来写多行，会不会好些一些
| * | ||
| * Argument in the Function: | ||
| * \param size_ represent N | ||
| * \param scale_ represent alpha / N |
There was a problem hiding this comment.
paper的公式，直接是 alpha，看代码实现了scale_等价公式里的alpha吧？ 不是alpha/N吧？ paper: https://papers.nips.cc/paper/4824-imagenet-classification-with-deep-convolutional-neural-networks.pdf
lizexu123
pushed a commit
to lizexu123/Paddle
that referenced
this pull request
Feb 23, 2024
* Update Some Demos & Add Infer for ImageNet Demo * Update Some Demos & Add Infer for ImageNet Demo * Update Some Demos & Add Infer for ImageNet Demo * Update Some Demos & Add Infer for ImageNet Demo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the comment of @emailweixu .
Each Function needs a comment, and
Normalization is a complex formula, I am not sure if it's clear. Please help to review this pr.