Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lgamma_op kernel and unittest #32913

Merged
merged 11 commits into from
May 28, 2021
Merged

Add lgamma_op kernel and unittest #32913

merged 11 commits into from
May 28, 2021

Conversation

levi131
Copy link
Contributor

@levi131 levi131 commented May 14, 2021 •
edited
Loading

PR types

New features

PR changes

OPs

Describe

Add lgamma op and unit test.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot-old
Copy link

paddle-bot-old bot commented May 14, 2021 •
edited
Loading

✅ This PR's description meets the template requirements!
Please wait for other CI results.

@levi131 levi131 changed the title Add lgamma and UNITtest. Add lgamma and unit test. May 14, 2021
@Aurelius84 Aurelius84 requested a review from Xreki May 26, 2021 11:10
Aurelius84
Aurelius84 approved these changes May 26, 2021
View reviewed changes
Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Xreki
Xreki approved these changes May 26, 2021
View reviewed changes
Copy link
Contributor

@Xreki Xreki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for op benchmark ci

@levi131 levi131 changed the title Add lgamma and unit test. Add lgamma_op kernel and unittest May 28, 2021
juncaipeng
juncaipeng approved these changes May 28, 2021
View reviewed changes
Copy link
Contributor

@juncaipeng juncaipeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aurelius84 Aurelius84 merged commit 2d3cbb4 into PaddlePaddle:develop May 28, 2021
@levi131 levi131 deleted the levi/add_lgamma_op branch June 10, 2021 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhhsplendid zhhsplendid zhhsplendid left review comments

@juncaipeng juncaipeng juncaipeng approved these changes

@Xreki Xreki Xreki approved these changes

@Aurelius84 Aurelius84 Aurelius84 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@levi131 @zhhsplendid @Aurelius84 @Xreki @juncaipeng