Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude lr scheduler's state from accumulators_holder #33984

Merged
merged 3 commits into from
Jul 14, 2021

Conversation

iclementine
Copy link

@iclementine iclementine commented Jul 6, 2021

PR types

Bug fixes

PR changes

APIs

Describe

Fix the bug that "an optimizer that has a learning rate scheduler who has called set_state_dict() before any update would cause an error in step() afterwards."

@paddle-bot-old
Copy link

paddle-bot-old bot commented Jul 6, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@iclementine iclementine requested review from phlrain and guoshengCS July 8, 2021 08:37
@iclementine iclementine requested a review from guoshengCS July 14, 2021 06:03
Copy link
Contributor

@guoshengCS guoshengCS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@chenwhql chenwhql left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iclementine iclementine merged commit 7d9bf24 into PaddlePaddle:develop Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants