Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dy2st]Integrated gast library to fix compatibility problem permanently #34556

Merged
merged 7 commits into from
Aug 5, 2021

Conversation

0x45f
Copy link
Contributor

@0x45f 0x45f commented Aug 2, 2021

PR types

Others

PR changes

Others

Describe

1. 背景

paddle中需要将gast三方库进行集成,来解决兼容性问题。

2. 方案

我们将gast库的源代码引入paddle中,将gast代码放到了 python/paddle/utils/gast 目录下,对 paddle 中 import gast 的代码进行了修改,对 requirements.txt文件进行了修改,不再需要安装gast库。同时咨询了法务的同学,对gast库的集成不会造成版权问题。

gast库github地址:https://github.com/serge-sans-paille/gast

版权说明:

Copyright (c) 2016, Serge Guelton
All rights reserved.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Aug 2, 2021

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@0x45f 0x45f changed the title [dy2st]Integrated gast library to fix compatibility problem permanently [Dy2st]Integrated gast library to fix compatibility problem permanently Aug 2, 2021
Aurelius84
Aurelius84 previously approved these changes Aug 3, 2021
Copy link
Contributor

@Aurelius84 Aurelius84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zhhsplendid
zhhsplendid previously approved these changes Aug 4, 2021
Copy link
Member

@zhhsplendid zhhsplendid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x45f 0x45f dismissed stale reviews from zhhsplendid and Aurelius84 via d6721a0 August 4, 2021 08:03
Copy link
Member

@zhhsplendid zhhsplendid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Aurelius84 Aurelius84 merged commit a9ee383 into PaddlePaddle:develop Aug 5, 2021
@0x45f 0x45f deleted the gast branch September 7, 2021 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants