add (N,C,*) input support for GroupNorm #34773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
zoooo0820
force-pushed
the
fix_GroupNorm
branch
from
2c293a1 to
183eb67
Compare
jerrywgz
reviewed
Aug 11, 2021
python/paddle/nn/layer/norm.py
Outdated
| @@ -338,8 +338,8 @@ class GroupNorm(Layer): | |||
| name(str, optional): Name for the GroupNorm, default is None. For more information, please refer to :ref:`api_guide_Name`.. | |||
|
|
|||
| Shape: | |||
| - x: 4-D tensor with shape: (batch, num_features, height, weight). | |||
| - output: 4-D tensor with same shape as input x. | |||
| - x: Tensor with shape: (N, C, *), where N is batch_size, C is num_features. | |||
There was a problem hiding this comment.
这里需要说明得更清晰些，比如tensor size的要求，不同的layout对应的shape也应该是不一样的。另外需要更新下fluiddoc下的中文文档
There was a problem hiding this comment.
目前该API只支持NCHW layout输入，参考相似API，中文文档已修改。
fluid doc预览
jerrywgz
approved these changes
Aug 17, 2021
dingjiaweiww
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Bug fixes
PR changes
OPs
Describe
The nn.GroupNorm is only support 4-D input now. However, there is no shape check for input tensor. So there are two type problems.
What this PR did: