Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PaddlePaddle Hackathon] add DenseNet #36069

Merged
merged 20 commits into from
Oct 27, 2021
Merged

[PaddlePaddle Hackathon] add DenseNet #36069

merged 20 commits into from
Oct 27, 2021

Conversation

fuqianya
Copy link
Contributor

@fuqianya fuqianya commented Sep 24, 2021 •
edited
Loading

PR types

New features

PR changes

APIs

Describe

Add DenseNet to Paddle Vision (include calling of higher-level api, test case and doc).
Doc is at PaddlePaddle/docs#3923.

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

This was referenced Sep 25, 2021
Merged
Closed
@fuqianya fuqianya changed the title add DenseNet [PaddlePaddle Hackathon] add DenseNet Sep 29, 2021
@fuqianya
Copy link
Contributor Author

@LielinJiang 老师，这里也需要review，麻烦老师啦！

LielinJiang
LielinJiang reviewed Oct 13, 2021
View reviewed changes
python/paddle/vision/models/densenet.py Outdated
if self.with_pool:
y = self.pool2d_avg(conv)

if self.num_classes:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里改为>0把，意义更明确

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的，已修改

@LielinJiang
Copy link
Contributor

LielinJiang commented Oct 13, 2021 •
edited
Loading

请参考这个PR：#36070
提个下自测代码和精度，并且确认可以实例化两次

@fuqianya
Copy link
Contributor Author

请参考这个PR：#36070 提个下自测代码和精度，并且确认可以实例化两次

老师，我已经自测过了，结果在 这里。

@fuqianya
Copy link
Contributor Author

@LielinJiang 老师,麻烦再review一下

LielinJiang
LielinJiang previously approved these changes Oct 20, 2021
View reviewed changes
@fuqianya
Copy link
Contributor Author

@TCChenlong @XiaoguangHu01 麻烦两个老师也review一下,谢谢!

@fuqianya
Copy link
Contributor Author

@LielinJiang 老师，合并了一下冲突，重新过了一下CI，麻烦重新review一下

LielinJiang
LielinJiang previously approved these changes Oct 25, 2021
View reviewed changes
@fuqianya
Copy link
Contributor Author

谢谢～

TCChenlong
TCChenlong previously approved these changes Oct 25, 2021
View reviewed changes
python/paddle/vision/models/densenet.py Show resolved Hide resolved
@fuqianya fuqianya dismissed stale reviews from TCChenlong and LielinJiang via 5a2c4ad October 25, 2021 05:42
@fuqianya
Copy link
Contributor Author

@LielinJiang @TCChenlong 麻烦老师重新aprrove一下，又重新修改过了一下CI

@fuqianya
Copy link
Contributor Author

@LielinJiang 老师，麻烦重新approve一下

XiaoguangHu01
XiaoguangHu01 approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG API

@LielinJiang LielinJiang merged commit c09fe14 into PaddlePaddle:develop Oct 27, 2021
ghost pushed a commit to piotrekobi/Paddle that referenced this pull request Nov 3, 2021
@fuqianya @piotrekobi
[PaddlePaddle Hackathon] add DenseNet (PaddlePaddle#36069)
673fe6c 
* add DenseNet
This was referenced Sep 6, 2022
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XiaoguangHu01 XiaoguangHu01 XiaoguangHu01 approved these changes

@TCChenlong TCChenlong TCChenlong approved these changes

@LielinJiang LielinJiang LielinJiang left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fuqianya @LielinJiang @TCChenlong @XiaoguangHu01