make all phi kernels to 2(host/device) static libraries directly #43247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
make all phi kernels to 2(host/device) static libraries directly, it can reduce about 3min of total compilation time.
each kernel is compiled to a static library
all kernels are compiled to 2 static libraries (libphi_cpu.a and libphi_gpu.a)
why
Consider A kernel uses B in its implementation, if each kernel is compiled to a static library, then libA depends on libB, and thus A is compiled after B, which may result in low concurrency in parellel compilation.
For example, in the following timeline, the
matrix_rank_tol_kernel
is compiled afterreduce_sum_kernel
since it reusereduce_sum
and other kernels. It is the last phi kernel compiled and only one thread(process) is being executed at that time even if the command ismake -j24
.after this pr,
matrix_rank_tol_kernel
can overlap with others.