support the 'generate_proposals' for generating static graph ops #52940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
Closed
| infer_meta : | ||
| func : GenerateProposalsV2InferMeta | ||
| kernel : | ||
| func : generate_proposals |
There was a problem hiding this comment.
增加data_type : anchors
| - op : generate_proposals | ||
| args : (Tensor scores, Tensor bbox_deltas, Tensor im_shape, Tensor anchors, Tensor variances, int pre_nms_top_n, int post_nms_top_n, float nms_thresh, float min_size, float eta, bool pixel_offset=true) | ||
| output : Tensor(rpn_rois), Tensor(rpn_roi_probs), Tensor(rpn_rois_num) | ||
| infer_meta : |
There was a problem hiding this comment.
增加optional : rpn_rois_num
| func : GenerateProposalsV2InferMeta | ||
| kernel : | ||
| func : generate_proposals | ||
| optional : rpn_rois_num |
There was a problem hiding this comment.
参考其他ops的optional data_type配置设置一下，这里的参数格式不对
fix bug
| inputs : | ||
| {scores : Scores, bbox_deltas : BboxDeltas, im_shape : ImShape, anchors : Anchors, variances : Variances} | ||
| outputs : | ||
| {rpn_rois : RpnRois, rpn_roi_probs : RpnRoiProbs, rpn_rois_num : RpnRoisNum} |
There was a problem hiding this comment.
可以通过ci-py3的错误信息同时结合xxx_op.cc文件，这里有部分attrs的name名字也需要映射。仔细对比xxx_op.cc文件和yaml中的名字进行修改，如"pre_nms_top_n"，请全面对比名字。
paddle/phi/api/yaml/op_compat.yaml
Outdated
| @@ -952,6 +952,12 @@ | |||
| extra : | |||
| attrs : [bool use_mkldnn = false, str mkldnn_data_type = "float32"] | |||
|
|
|||
| - op : generate_proposals(generate_proposals_v2) | |||
| inputs : | |||
| {scores : Scores, bbox_deltas : BboxDeltas, im_shape : ImShape, anchors : Anchors, variances : Variances, pre_nms_top_n : pre_nms_topN, post_nms_top_n : post_nms_topN} | |||
There was a problem hiding this comment.
inputs里只会有tensor类型的参数，其余类型的要配置到attrs中，可以参考其他算子的配置。
There was a problem hiding this comment.
原来是这样，之前就好奇 inputs 和 attrs有什么区别，看到有的用inputs，有的用 attrs，还以为这两个都可以
lijialin03
pushed a commit
to lijialin03/Paddle
that referenced
this pull request
Apr 25, 2023
…dlePaddle#52940) * support the 'generate_proposals' for generating static graph ops * fix bug * fix bug * Update ops.yaml fix bug * remove the generate_proposals_v2_op.cc from CMakeLists.txt * fix bug * fix bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description
add autogen code support for generate_proposals
#51842