Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【fix bug】Fix bug in parse args with '{,}' #52968

Merged

Conversation

heavyrain-lzy
Copy link
Contributor

PR types

Others

PR changes

OPs

Describe

Pcard-67001
修复之前parse agrs时的潜在的bug,当args含有int[] a = {1, 100}这种形式的配置时,简单的split.(",")已经不能满足,现修改为re正则表达式匹配。

@paddle-bot
Copy link

paddle-bot bot commented Apr 16, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

Copy link
Contributor

@jiahy0825 jiahy0825 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heavyrain-lzy heavyrain-lzy merged commit be04f25 into PaddlePaddle:develop Apr 17, 2023
jjyaoao pushed a commit to jjyaoao/Paddle that referenced this pull request Apr 19, 2023
* fix bug in parse args

* fix bug

* recover legacy_*.yaml

* change 'Out' to Output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants