[cmake] add brpc third party cache #54522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
你的PR提交成功，感谢你对开源项目的贡献! |
|
@risemeup1，帮忙看一个问题，CI-CINN 几个单测报错，报的错有点奇怪，Rerun 了也没用，我本地用 CI 的 cmake 编译能够复现，然后我切换回 develop 分支编译（删了 build/third_party）还是会报错 |
CINN本地的问题，他们在修复 |
Closed
huangjiyi
commented
Jun 13, 2023
Comment on lines
67
to
+68
| CMAKE_ARGS -DCMAKE_INSTALL_PREFIX=${LIBMCT_INSTALL_ROOT} | ||
| -DCMAKE_BUILD_TYPE=${THIRD_PARTY_BUILD_TYPE} | ||
| CMAKE_CACHE_ARGS -DCMAKE_INSTALL_PREFIX:PATH=${LIBMCT_INSTALL_ROOT} | ||
| -DCMAKE_BUILD_TYPE=${THIRD_PARTY_BUILD_TYPE}) | ||
| CMAKE_CACHE_ARGS -DCMAKE_INSTALL_PREFIX:PATH=${LIBMCT_INSTALL_ROOT}) |
There was a problem hiding this comment.
改这里是为了修复一个 CMake Warning（同 xbyak.cmake）：
CMake Warning at /home/cmake-3.18.0-Linux-x86_64/share/cmake-3.18/Modules/ExternalProject.cmake:1641 (message):
Line 'CMAKE_BUILD_TYPE=Release' does not match regex. Ignoring.
Call Stack (most recent call first):
/home/cmake-3.18.0-Linux-x86_64/share/cmake-3.18/Modules/ExternalProject.cmake:2904 (_ep_command_line_to_initial_cache)
/home/cmake-3.18.0-Linux-x86_64/share/cmake-3.18/Modules/ExternalProject.cmake:2941 (_ep_extract_configure_command)
/home/cmake-3.18.0-Linux-x86_64/share/cmake-3.18/Modules/ExternalProject.cmake:3227 (_ep_add_configure_command)
cmake/external/libmct.cmake:57 (ExternalProject_Add)
cmake/third_party.cmake:407 (include)
CMakeLists.txt:566 (include)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Description